[#CMP-231] Configuration of ram:// and mmap:// have their path attribute not parsed

Compass

Configuration of ram:// and mmap:// have their path attribute not parsed

Created: 25/Jul/06 09:56 AM Updated: 26/Jul/06 06:18 AM

Component/s:

Compass::Core

Affects Version/s:

1.0.0

Fix Version/s:

1.0.1, 1.1 M1

Description

« Hide

The code in org.compass.core.config.builder.SchemaConfigurationBuilder does not parse the "path" attribute for ram and mmap connections:
(around line 353 in release 1.0.0)

child = DomUtils.getChildElementsByTagName(ele, "mmap", true);
if (child.size() == 1) {
Element connEle = (Element) child.get(0);
String path = DomUtils.getElementAttribute(connEle, "mmap");<------ should be "path"
if (!path.startsWith("mmap://")) { path = "mmap://" + path; }
settings.setSetting(CompassEnvironment.CONNECTION, path);
return;
}
// — RAM Connection —
child = DomUtils.getChildElementsByTagName(ele, "ram", true);
if (child.size() == 1) {
Element connEle = (Element) child.get(0);
String path = DomUtils.getElementAttribute(connEle, "ram"); //<------ should be "path"
if (!path.startsWith("ram://")) { path = "ram://" + path; }
settings.setSetting(CompassEnvironment.CONNECTION, path);
return;
}

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Shay Banon added a comment - 26/Jul/06 06:18 AM

Nice catch, and thanks for tracking down the problem so my life is simpler.

I fixed it in both 1.1 M1 and 1.0 branch, since it is a major bug. It means that it should be available soon under 1.1 M1 SNAPSHOT, and will be part of the 1.0.1 bug fix release.