SourceForge.net Logo
Main Overview Wiki Issues Forum Build Fisheye
Issue Details (XML | Word | Printable)

Key: CMP-296
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Shay Banon
Reporter: Christopher Barham
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Compass

in CompassSearchController doProcessAfterDetach is never called if page number not supplied

Created: 19/Oct/06 09:00 PM   Updated: 21/Oct/06 11:36 AM
Component/s: Compass::Spring
Affects Version/s: 1.1 M3
Fix Version/s: 1.1 M3

Environment: All


 Description  « Hide
In the source for org.compass.spring.web.mvc.CompassSearchController (I'll use line numbers from the SVN browse page at: http://svn.opensymphony.com/fisheye/browse/compass/trunk/src/main/src/org/compass/spring/web/mvc/CompassSearchController.java?r=1210 ) line number 105-107 cater for when the call to performSearch comes in with no page number.

Although the extension point doProcessBeforeAttach is called in these circumstances, after the detach, the other extension point doProcessAfterDetach is never called.

e.g.: I reckon this code snippet:
...
105 if (pageSize == null) { 106 doProcessBeforeDetach(searchCommand, session, hits, -1, -1); 107 detachedHits = hits.detach(); 108 } else {
...

Perhaps should look like:
105 if (pageSize == null) { 106 doProcessBeforeDetach(searchCommand, session, hits, -1, -1); 107 detachedHits = hits.detach(); 108 doProcessAfterDetach(searchCommand, session, detachedHits); 108 } else {
...

Chris



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Shay Banon added a comment - 21/Oct/06 11:36 AM
Yep, this is a bug. Fixed it and is already part of 1.1 M3 SNAPSHOT.