SourceForge.net Logo
Main Overview Wiki Issues Forum Build Fisheye
Issue Details (XML | Word | Printable)

Key: CMP-373
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Shay Banon
Reporter: Jonas Van Poucke
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Compass

CompassTemplate does not support changing settings on the session

Created: 19/Feb/07 03:56 AM   Updated: 20/Apr/07 05:42 PM
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2 M1


 Description  « Hide
CompassTemplate does not allow to override the settings in the session, because a new one is created on each call to CompassTemplate.getSettings(). This is because session.getSettings is callled in a callback and the callback creates a new session on each invocation:
public CompassSettings getSettings() {
return (CompassSettings) execute(new CompassCallback() {
public Object doInCompass(CompassSession session) throws CompassException { return session.getSettings(); // A new session each time CompassTemplate.this.getSettings() is called }
});
}

Fix: CompassTemplate should keep its own session settings and copy those when execute() is called.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Shay Banon added a comment - 02/Mar/07 12:51 AM
It was a mistake to include getSettings in the CompassOperations interface. I have removed it from there and added it to CompassSession.

I have added globalSEssionSettigns to CompasTemplate. So you can either change that, or change the session settings by using execute.