SourceForge.net Logo
Main Overview Wiki Issues Forum Build Fisheye
Issue Details (XML | Word | Printable)

Key: CMP-532
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Shay Banon
Reporter: Kenny MacLeod
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Compass

AbstractInputStreamMappingBinding does not close stream

Created: 06/Feb/08 11:44 AM   Updated: 06/Feb/08 11:56 AM
Component/s: Compass::Core
Affects Version/s: 2.0 M1
Fix Version/s: 1.2.2, 2.0.0 M2


 Description  « Hide
The addInputStream() method of AbstractInputStreamMappingBinding does not close its InputStream in cases where it rejects the input due to an invalid suffix.

The suffix check should be moved inside the try/finally block to ensure stream closure.

While I'm here, could you make Compass log some error messages when things like the suffix don't match? It's frustrating when it just silently rejects things without telling you why.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Shay Banon added a comment - 06/Feb/08 11:56 AM
Fixed closing the stream, also added logger trace level message