[#CMP-784] ResultSetJdbcGpsDevice.snapshot should be protected and have a getter

Compass

ResultSetJdbcGpsDevice.snapshot should be protected and have a getter

Created: 24/Nov/08 04:49 AM Updated: 24/Nov/08 04:22 PM

Component/s:

Compass::Gps

Affects Version/s:

2.1.0 GA

Fix Version/s:

2.2.0 M1

Description

« Hide

See the title.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Shay Banon added a comment - 24/Nov/08 04:04 PM

Why do you need to access it? Once I expose something like that, it means that refactoring of it will be harder...

[ Permlink | « Hide ]

Fábio Matos added a comment - 24/Nov/08 04:18 PM

I need access to that variable because I extended the ResultSetJdbcGpsDevice (to implement the refresh method) and I don't call the index method of the Gps (that would call the doIndex of the GpsDevice).

Not calling index and using a FSJdbcSnapshotPersister, the snapshot will never be saved correctly. Whenever you load the snapshot (line 176 of ResultSetJdbcGpsDevice ), because it was not saved before, it will always return a new one.

Conclusion, I needed access to the snapshot variable to be able to call getSnapshotPersister().save(snapshot) from my extended ResultSetJdbcGpsDevice before the doStart method is executed.

[ Permlink | « Hide ]

Shay Banon added a comment - 24/Nov/08 04:22 PM

ok, added getJdbcSnapshot (protected one)