|
[
Permlink
| « Hide
]
Shay Banon added a comment - 07/Sep/09 03:27 PM
I have committed a fix and kicked in a nightly build of trunk (2.3). Can you give it a go (in 30 minutes)?
Hi Shay,
sorry for late reply , i could not get notification of the update .. I took the following compass changes for the fix and did a build
i could see that you have made a code change in the file PlainMappingBinding.java and have included the above reported structure in the file mapping.cpm.xml. as rootobject "d" ..... conf.addMapping( Now , the test will pass ..... Conclusion: if we make the mapping using programmatic builder API ( eg , conf.addMapping(json(d).add ....... ) , then a structure which has an object inside object works well ... but if we make the same mapping using fully explicit mappings ( eg <json-rootobject alias="d" ... ) then compass goes into stack overflow error. The error still persists.. Please let me know if you need any more information. Regards I have ran SimpleJsonObjectTests which does loads the mentioned mapping file. I recreated the stack overflow exception, and fixed it in the commit.
Just for kicks, I added the same programmatic to SimpleJsonObjectBuilderTests and it passes as well. I also added an actual test to verify the indexing work. Can you simply double check with trunk? Hi Shay,
the problem still seems to persist. btw, in the change log i could find the following files that are changed, but all the below 3 files looks like to be part of test suite and not part of the fix ... am i missing something ???
The above 3 files are the only changes that i took from yestarday's build .. It is very likely that i might missing the files which have the actual fix.. Thanks and Regards Hi,
This is very strange. The changes I did are indeed just changes to the testing to test the mapping you gave more properly. When I run the tests, they pass, so I don't really understand what does not pass for you. Shay Hi Shay,
I really appologise for the inconvenience caused ...iam not getting the stack overflow error now ... I was using a wrong value for classpath( which was taking compass2.2.0 instead of your trunk build ) Thanks a lot for your time on the issue .. Thanks a lot again.... Regards No problem, I should thank you for spotting this bug and helping fix it!
|
||||||||||||||||||||||||||||||||||||||||||